Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: property overrides in EncodecModel #322

Closed
wants to merge 1 commit into from
Closed

refactor: property overrides in EncodecModel #322

wants to merge 1 commit into from

Conversation

0xlws
Copy link
Contributor

@0xlws 0xlws commented Oct 18, 2023

this pull request redefines abstract properties frame_rate, sample_rate, and channels in EncodecModel which are inherited from ABC CompressionModel

class vars -> instance vars

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2023
@JadeCopet
Copy link
Contributor

Thanks but we'd rather not change this part.

@JadeCopet JadeCopet closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xlws @JadeCopet @facebook-github-bot