Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganizing objects created in CLI #376

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reorganizing objects created in CLI #376

wants to merge 4 commits into from

Conversation

arnavsacheti
Copy link
Contributor

Summary: Moving some imports to be inside of if statements when possible to move closer to only creating instances when needed

Differential Revision: D38009745

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 21, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D38009745

Arnav Sacheti added 4 commits July 26, 2022 13:59
@facebook-github-bot
Creating KMS gateway and service (facebookresearch#366)
ba4b2c0 
Summary:
Pull Request resolved: facebookresearch#366

# What are Grant Tokens
https://docs.aws.amazon.com/kms/latest/developerguide/grants.html

Reviewed By: ziqih

Differential Revision: D37400919

fbshipit-source-id: 28d9a3ed111b5a1a46ff59fbc575fb9b5e55313c
@facebook-github-bot
Adding support for message signature (facebookresearch#377)
7a76761 
Summary: Pull Request resolved: facebookresearch#377

Reviewed By: ziqih

Differential Revision: D37974927

fbshipit-source-id: 410aa1b31bfddcd9db35dbede0b7e75180345f79
@facebook-github-bot
Adding support for message verification (facebookresearch#378)
e943ea6 
Summary: Pull Request resolved: facebookresearch#378

Differential Revision: D37667144

fbshipit-source-id: 32142cb73fe6d0f0a62090a18c3e455a5a4dc355
@facebook-github-bot
Reorganizing objects created in CLI (facebookresearch#376)
6862db8 
Summary:
Pull Request resolved: facebookresearch#376

Moving some imports to be inside of if statements when possible to move closer to only creating instances when needed

Differential Revision: D38009745

fbshipit-source-id: 06fa60169209774dddeb7bd0591b6f644122a04d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D38009745

@facebook-github-bot
Copy link
Contributor

Hi @IamStegoMan!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnavsacheti @facebook-github-bot