Add CPU & memory to ContainerInstance #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38553232 |
ziqih
added a commit
to ziqih/fbpcp
that referenced
this pull request
Aug 9, 2022
Summary: Pull Request resolved: facebookresearch#400 ## Context We want to enable customized containers in our infra ([design doc](https://docs.google.com/document/d/1UqaK6VXEoIVUHSJnYs_Ydju8)). Therefore we need to add cpu & memory specs to ContainerInstance; ## This commit - Add CPU & Memory to ContainerInstance - Parse them in map_ecstask_to_containerinstance ## How this effect ```pcs_container_instance.py```? Since ```PCSContainerInstance``` inherits ```ContainerInstance```, we change it to use keyword argument for ```log_url``` to prevent breaks; Differential Revision: D38553232 fbshipit-source-id: 03b0db99d649dee08abd0b027c95496e5550daf1
|
This pull request was exported from Phabricator. Differential Revision: D38553232 |
Summary: Pull Request resolved: facebookresearch#400 ## Context We want to enable customized containers in our infra ([design doc](https://docs.google.com/document/d/1UqaK6VXEoIVUHSJnYs_Ydju8)). Therefore we need to add cpu & memory specs to ContainerInstance; ## This commit - Add CPU & Memory to ContainerInstance - Parse them in map_ecstask_to_containerinstance ## How this affect ```pcs_container_instance.py```? Since ```PCSContainerInstance``` inherits ```ContainerInstance```, we change it to use keyword argument for ```log_url``` to prevent breaks; If needed by PSI team, we can also add cpu and memory to ```PCSContainerInstance``` (see code in V1) Differential Revision: D38553232 fbshipit-source-id: b53c7f9f6788dbb702944371f61372013010ae6e
|
This pull request was exported from Phabricator. Differential Revision: D38553232 |
ziqih
added a commit
to ziqih/fbpcs
that referenced
this pull request
Aug 10, 2022
…h#400) Summary: X-link: facebookresearch/fbpcp#400 ## Context We want to enable customized containers in our infra ([design doc](https://docs.google.com/document/d/1UqaK6VXEoIVUHSJnYs_Ydju8)). Therefore we need to add cpu & memory properties to ContainerInstance; ## This commit Change ```PCSContainerInstance``` to use keyword arguments to prevent breaks when we add cpu and memory to ```ContainerInstance ``` later Differential Revision: D38553232 fbshipit-source-id: b96624305a4443e5ec7801d0f44f258132bceba0
facebook-github-bot
pushed a commit
to facebookresearch/fbpcs
that referenced
this pull request
Aug 10, 2022
Summary: Pull Request resolved: #1421 X-link: facebookresearch/fbpcp#400 ## Context We want to enable customized containers in our infra ([design doc](https://docs.google.com/document/d/1UqaK6VXEoIVUHSJnYs_Ydju8)). Therefore we need to add cpu & memory properties to ContainerInstance; ## This commit Change ```PCSContainerInstance``` to use keyword arguments to prevent breaks when we add cpu and memory to ```ContainerInstance ``` later Reviewed By: joe1234wu Differential Revision: D38553232 fbshipit-source-id: b0a004a5435e08737ac9e86243bb06b9dfbb9a27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
We want to enable customized containers in our infra (design doc). Therefore we need to add cpu & memory specs to ContainerInstance;
This commit
How this effect
pcs_container_instance.py?Since
PCSContainerInstanceinheritsContainerInstance, we change it to use keyword argument forlog_urlto prevent breaks;Differential Revision: D38553232