Skip to content

Commit

Permalink
return server_uris from mpc instance (#1912)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1912

This change will return the server_uris dynamically based on what was passed in during instance creation. With D41204111 (d7114ca) to migrate MPCInstance from fbpcp to fbpcs, we don't need fbpcp release to make this change.

Reviewed By: joe1234wu

Differential Revision: D41226001

fbshipit-source-id: a7f720c8de832c958d93e62f0519057643363705
  • Loading branch information
YigeZhu authored and facebook-github-bot committed Nov 11, 2022
1 parent d7114ca commit 2462a1b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions fbpcs/common/entity/pcs_mpc_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,5 @@ def from_mpc_instance(
mpc_instance.containers,
mpc_instance.status,
mpc_instance.game_args,
# TODO: Replace this static value with dynamic value returned from MPCInstance
# when fbpcp is released (D40948331) with the changes in (D40917008)
DEFAULT_SERVER_URIS if tls_enabled else None,
mpc_instance.server_uris,
)

0 comments on commit 2462a1b

Please sign in to comment.