Move PCF2-Lift Options to a shared location #2198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 17, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Differential Revision: D44062784 fbshipit-source-id: 98950f8f15f994a53b6a20e2ed66daecc4b7c2bc
calebzj
force-pushed
the
export-D44062784
branch
from
4254489
to
2842869
Compare
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 17, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Differential Revision: D44062784 fbshipit-source-id: 888fbce44832fd5be3fe2e30c7d3fc60cf29f223
calebzj
force-pushed
the
export-D44062784
branch
from
2842869
to
b54e38e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 17, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Differential Revision: D44062784 fbshipit-source-id: 0f13d31ef882d6eb3b4908fa53a4b7eafe5d1f7c
calebzj
force-pushed
the
export-D44062784
branch
from
b54e38e
to
789efab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 20, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Reviewed By: ajinkya-ghonge, haochenuw Differential Revision: D44062784 fbshipit-source-id: 4ed6f17f5e0200600324254e58f94904c00d0fa2
calebzj
force-pushed
the
export-D44062784
branch
from
789efab
to
81992b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
force-pushed
the
export-D44062784
branch
from
81992b6
to
5286b80
Compare
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 24, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Reviewed By: ajinkya-ghonge, haochenuw Differential Revision: D44062784 fbshipit-source-id: 3e1779d48b003ee1ac16dc4e77e47a3c80e0f111
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 27, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Reviewed By: ajinkya-ghonge, haochenuw Differential Revision: D44062784 fbshipit-source-id: d2ea44f9edaa045666ce5ff0095481af225b243c
calebzj
force-pushed
the
export-D44062784
branch
from
5286b80
to
215c27b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Reviewed By: ajinkya-ghonge, haochenuw Differential Revision: D44062784 fbshipit-source-id: 46b4dc7fc95f14d24eeed32462569f4c3ffad9fe
calebzj
force-pushed
the
export-D44062784
branch
from
215c27b
to
b880191
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
force-pushed
the
export-D44062784
branch
from
b880191
to
8680d5e
Compare
calebzj
pushed a commit
to calebzj/fbpcs
that referenced
this pull request
Mar 30, 2023
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Reviewed By: ajinkya-ghonge, haochenuw Differential Revision: D44062784 fbshipit-source-id: 2874edb15d3c5abc67630e1a2192484017866136
Summary: Pull Request resolved: facebookresearch#2198 This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code. Reviewed By: ajinkya-ghonge, haochenuw Differential Revision: D44062784 fbshipit-source-id: c63c45566219ec11272ac58c2efbb7c7437d1f21
|
This pull request was exported from Phabricator. Differential Revision: D44062784 |
calebzj
force-pushed
the
export-D44062784
branch
from
8680d5e
to
6ca79a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.
Differential Revision: D44062784