Skip to content

Conversation

rohan-varma
Copy link
Contributor

Summary: There have been some fixes to the non-reentrant AC and FLAVA model now works with it.

Differential Revision: D47218368

rohan-varma and others added 2 commits July 6, 2023 17:12
Summary: ShardedGradScaler not needed for bf16 training.

Differential Revision: D47218367

fbshipit-source-id: 143269cc8dc05805b3caebe73035ce0f39c7e8d4
Summary: There have been some fixes to the non-reentrant AC and FLAVA model now works with it.

Differential Revision: D47218368

fbshipit-source-id: 448969eb42e6df224dcd7ea82b4fabe63dcecf96
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47218368

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (94979e2) 68.61% compared to head (aefeaea) 68.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   68.61%   68.63%   +0.01%     
==========================================
  Files         169      169              
  Lines       11338    11336       -2     
==========================================
  Hits         7780     7780              
+ Misses       3558     3556       -2     
Impacted Files Coverage Δ
examples/flava/native/train.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ankitade ankitade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the test plan with a cmd you ran

Copy link

meta-cla bot commented Aug 30, 2025

Hi @rohan-varma!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants