Moving flava model to its own folder #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## gh/ankitade/2/base #96 +/- ##
======================================================
- Coverage 88.96% 88.85% -0.12%
======================================================
Files 33 33
Lines 1722 1722
======================================================
- Hits 1532 1530 -2
- Misses 190 192 +2
Continue to review full report at Codecov.
|
[ghstack-poisoned]
|
@ankitade has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ebsmothers
approved these changes
Jun 20, 2022
| with self.assertRaises(ValueError): | ||
| _ = FLAVASelfAttention(hidden_size=3, num_attention_heads=2) | ||
|
|
||
| def test_flava_transformer_without_embeddings_value_error(self): |
There was a problem hiding this comment.
Just wondering, why remove this?
There was a problem hiding this comment.
its an unrelated test that got checked in by mistake while separating out transformers
This was referenced Jun 21, 2022
ankitade
added a commit
to ankitade/multimodal
that referenced
this pull request
Jun 24, 2022
Summary: Pull Request resolved: facebookresearch#96 Create a flava directory under models and move flava.py there in preparation for separating out flava text and image encoders in that directory Test Plan: Imported from OSS Differential Revision: D37284910 fbshipit-source-id: 4638403d7338c0678e0aab7f6b40c7b3672da0e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a flava directory under models and move flava.py there in preparation for separating out flava text and image encoders in that directory
Stack from ghstack (oldest at bottom):
Differential Revision: D37284910