Add a fast path in _matrix_perturbation(epsilon=0.0) to simplify caller sides
#186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76242419 |
|
This pull request was exported from Phabricator. Differential Revision: D76242419 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Jun 12, 2025
…ller sides (facebookresearch#186) Summary: Pull Request resolved: facebookresearch#186 - The fast path is used when `epsilon=0.0`, which helps stabilize the following scenarios in `stabilize_and_pow_eigenvalues(rank_deficient_stability_config=PerturbationConfig())`: - `perturb_before_computation=True` and `lambda_min = 0.0`. - `perturb_before_computation=True` and `lambda_min > 0.0`. - `epsilon = 0.0`. - Remove outdated comments mentioning "DampingConfig". [This failed before](https://github.com/facebookresearch/optimizers/actions/runs/15541753042/job/43772139730) was due to missing [gajjanag's fix](facebookresearch#185). Differential Revision: D76242419
tsunghsienlee
force-pushed
the
export-D76242419
branch
from
fb99c39 to
c074859
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76242419 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Jun 13, 2025
…ller sides (facebookresearch#186) Summary: Pull Request resolved: facebookresearch#186 - The fast path is used when `epsilon=0.0`, which helps stabilize the following scenarios in `stabilize_and_pow_eigenvalues(rank_deficient_stability_config=PerturbationConfig())`: - `perturb_before_computation=True` and `lambda_min = 0.0`. - `perturb_before_computation=True` and `lambda_min > 0.0`. - `epsilon = 0.0`. - Remove outdated comments mentioning "DampingConfig". [This failed before](https://github.com/facebookresearch/optimizers/actions/runs/15541753042/job/43772139730) was due to missing [gajjanag's fix](facebookresearch#185). Differential Revision: D76242419
tsunghsienlee
force-pushed
the
export-D76242419
branch
from
c074859 to
c70c7a6
Compare
…ller sides (facebookresearch#186) Summary: Pull Request resolved: facebookresearch#186 - The fast path is used when `epsilon=0.0`, which helps stabilize the following scenarios in `stabilize_and_pow_eigenvalues(rank_deficient_stability_config=PerturbationConfig())`: - `perturb_before_computation=True` and `lambda_min = 0.0`. - `perturb_before_computation=True` and `lambda_min > 0.0`. - `epsilon = 0.0`. - Remove outdated comments mentioning "DampingConfig". [This failed before](https://github.com/facebookresearch/optimizers/actions/runs/15541753042/job/43772139730) was due to missing [gajjanag's fix](facebookresearch#185). Differential Revision: D76242419
|
This pull request was exported from Phabricator. Differential Revision: D76242419 |
tsunghsienlee
force-pushed
the
export-D76242419
branch
from
c70c7a6 to
5b256bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
epsilon=0.0, which helps stabilize the following scenarios instabilize_and_pow_eigenvalues(rank_deficient_stability_config=PerturbationConfig()):perturb_before_computation=Trueandlambda_min = 0.0.perturb_before_computation=Trueandlambda_min > 0.0.epsilon = 0.0.This failed before was due to missing @gajjanag 's fix.
Differential Revision: D76242419