Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Extraction - Refactor command-line script into a Python module #4

Merged
merged 18 commits into from
Dec 3, 2024

Conversation

JooZef315
Copy link
Contributor

@JooZef315 JooZef315 commented Oct 21, 2024

Purpose

This PR converts an existing command-line script launch_feature_extraction.py into a Python module for better structure, reuse, and test coverage.

Summary of Changes

  1. Refactored the original script into a Python module (feature_extraction_module.py).
  2. Created a test suite using unittest to validate the functionality of the module.

Testing Instructions

  1. Run unittest to execute the tests: python -m unittest tests/feature_extraction_test.py

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 21, 2024
@JooZef315 JooZef315 changed the title Initial Contributions - Feature Extraction Feature Extraction - Refactor command-line script into a Python module Oct 23, 2024
fairseq-sl/fairseq/data/data_utils_fast.cpp Outdated Show resolved Hide resolved
fairseq-sl/fairseq/data/token_block_utils_fast.cpp Outdated Show resolved Hide resolved
fairseq-sl/pip Outdated Show resolved Hide resolved
tests/feature_extraction_test.py Outdated Show resolved Hide resolved
tests/feature_extraction_test.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@heffernankevin heffernankevin merged commit 9a01374 into facebookresearch:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants