-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Extraction - Refactor command-line script into a Python module #4
Merged
heffernankevin
merged 18 commits into
facebookresearch:main
from
JooZef315:feature_extraction
Dec 3, 2024
Merged
Feature Extraction - Refactor command-line script into a Python module #4
heffernankevin
merged 18 commits into
facebookresearch:main
from
JooZef315:feature_extraction
Dec 3, 2024
+362
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Oct 21, 2024
JooZef315
changed the title
Initial Contributions - Feature Extraction
Feature Extraction - Refactor command-line script into a Python module
Oct 23, 2024
heffernankevin
requested changes
Nov 4, 2024
JooZef315
force-pushed
the
feature_extraction
branch
from
November 6, 2024 14:10
789d7e7
to
5765524
Compare
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
JooZef315
force-pushed
the
feature_extraction
branch
from
November 6, 2024 14:11
5765524
to
a2b387a
Compare
heffernankevin
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR converts an existing command-line script
launch_feature_extraction.py
into a Python module for better structure, reuse, and test coverage.Summary of Changes
feature_extraction_module.py
).unittest
to validate the functionality of the module.Testing Instructions
unittest
to execute the tests:python -m unittest tests/feature_extraction_test.py