Run Translation - Refactor command-line script into a Python module #8
+309
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
heffernankevin
requested changes
Nov 4, 2024
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
Signed-off-by: Joozef315 <[email protected]>
JooZef315
force-pushed
the
run_translation
branch
from
c58c49a
to
2acfaac
Compare
|
|
||
| # This source code is licensed under the license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
| # -------------------------------------------------------- |
There was a problem hiding this comment.
Let's be consistent about the license header here (it's important because those headers are automatically parsed by our bot and it will raise warning / error if the format is not recognized)
heffernankevin
requested changes
Nov 17, 2024
| from omegaconf import OmegaConf | ||
|
|
||
| # Add the parent directory to sys.path so it can locate the `translation` folder | ||
| sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))) |
There was a problem hiding this comment.
I'd suggest removing this, and just specifying a fully qualified path
JooZef315
force-pushed
the
run_translation
branch
from
d4c81c8
to
fc3fafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR converts an existing command-line script
run_translation.pyinto a Python module for better structure, reuse, and test coverage.Summary of Changes
run_translation_module.py).unittestto validate the functionality of the module.Testing Instructions
unittestto execute the tests:python -m unittest tests/translation_module_test.py