Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add synced crosshairs #178

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

feat: Add synced crosshairs #178

wants to merge 29 commits into from

Conversation

DaveSkender
Copy link
Member

@DaveSkender DaveSkender commented Jan 16, 2022

Fixes #141
Try again with new v2.0, may need to fork and update AbelHeinsbroek/chartjs-plugin-crosshair.

To do:

  • get sync groups working, so it spans across charts
  • refactor all typings stuff, it's a mess
  • legend params not placeholders not filled

this may require a Fork n' Fix of the plugin

@DaveSkender DaveSkender added the on hold Waiting for a dependency label Feb 16, 2022
@DaveSkender DaveSkender removed the on hold Waiting for a dependency label Aug 25, 2023
@DaveSkender DaveSkender changed the title add crosshairs feat: Add synced crosshairs Jan 7, 2024
Copy link

cloudflare-pages bot commented Feb 27, 2024

Deploying stock-charts with  Cloudflare Pages  Cloudflare Pages

Latest commit: db2c709
Status: ✅  Deploy successful!
Preview URL: https://b3b72cfe.stock-charts.pages.dev
Branch Preview URL: https://crosshairs.stock-charts.pages.dev

View logs

@DaveSkender
Copy link
Member Author

Current situation is that the crosshairs work; however, they're no longer syncing across charts like they used to (before we had to remove with charts.js v4 incompatible upgrades).

image

@DaveSkender DaveSkender self-assigned this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Add chartjs-plugin-crosshair after > v1.2.0 released with fixes
1 participant