Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add standard values from gsheet #47

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

venu-sambarapu-DS
Copy link
Collaborator

Changed default path to read standard dataset is changed to Google sheet master_dictionaries

Copy link
Contributor

@paul-tharun paul-tharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove debugging print statements
  • Remove code if it is not being used do not just comment it out
  • Add sheet id to be taken from env rather than hard coding it


# convert to json
json_compatible_item_data = jsonable_encoder(
entity_df.to_dict(orient="records")
)
print(json_compatible_item_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debugging print statements

@venu-sambarapu-DS venu-sambarapu-DS merged commit 9e5de0d into main Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants