chore(user-agent): add runtime info #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgawande12
approved these changes
Jun 7, 2024
|
I think your commits arent signed but I guess you can bypass this for now and just squash merge. What do we think @factset/enterprise-sdk |
gdulafactset
approved these changes
Jun 7, 2024
Filip1x9
force-pushed
the
chore/user-agent/runtime-info
branch
from
7660872 to
13162a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add runtime info such as OS and .NET version to the
User-Agentheader.Links
Testing
Checklist
Ensure the following things have been met before requesting a review: