fix: race-condition on token request close to expiry

factset · Aug 27, 2024 · 9902e2b · 9902e2b
1 parent 6b8a58d
commit 9902e2b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/fds/sdk/utils/authentication/confidential.py b/src/fds/sdk/utils/authentication/confidential.py
@@ -242,7 +242,7 @@ def _is_cached_token_valid(self) -> bool:
         if not self._cached_token:
             log.debug("Access Token cache is empty")
             return False
-        if time.time() < self._cached_token[CONSTS.TOKEN_EXPIRES_AT] - 30:
+        if time.time() < self._cached_token[CONSTS.TOKEN_EXPIRES_AT] - CONSTS.TOKEN_EXPIRY_OFFSET_SECS:
             return True
         else:
             log.debug("Cached access token has expired at %s", self._cached_token[CONSTS.TOKEN_EXPIRES_AT])

diff --git a/src/fds/sdk/utils/authentication/constants.py b/src/fds/sdk/utils/authentication/constants.py
@@ -14,6 +14,7 @@ class CONSTS:
     # access token
     TOKEN_ACCESS_TOKEN = "access_token"
     TOKEN_EXPIRES_AT = "expires_at"
+    TOKEN_EXPIRY_OFFSET_SECS = 30
 
     # config
     CONFIG_CLIENT_ID = "clientId"