chore: improve response data on confirmation message

facturacr · Oct 5, 2024 · 68b54d7 · 68b54d7
1 parent b301ac2
commit 68b54d7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/examples/createAndSend.ts b/examples/createAndSend.ts
@@ -7,7 +7,6 @@ import { PersonProps } from 'dist/src/ATV/core/Person'
 const IS_STG = process.env.IS_STG
 const USERNAME_TEST = process.env.USERNAME_TEST
 const PASSWORD_TEST = process.env.PASSWORD_TEST
-console.log('process.env.IS_STG', IS_STG)
 
 const SOURCE_P12_URI = process.env.SOURCE_P12_URI
 const SOURCE_P12_PASSPORT = process.env.SOURCE_P12_PASSPORT
@@ -18,8 +17,11 @@ if (!SOURCE_P12_PASSPORT || !SOURCE_P12_URI) {
 
 const pem = fs.readFileSync(SOURCE_P12_URI, 'binary')
 
+const paramConsecutive = process.argv[2]
+console.log('paramConsecutive', paramConsecutive)
+
 // TODO: dynamic param --identifier 1 args[x]
-createDocumentInputExample.consecutiveIdentifier = process.env.TEST_CONSECUTIVE
+createDocumentInputExample.consecutiveIdentifier = paramConsecutive || process.env.TEST_CONSECUTIVE 
 createDocumentInputExample.emitter.identifier.id = process.env.EMITTER_IDENTIFIER_ID as string;
 createDocumentInputExample.emitter.identifier.type = process.env.EMITTER_IDENTIFIER_TYPE as PersonProps['identifier']['type'];
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@facturacr/atv-sdk",
-  "version": "1.2.7",
+  "version": "1.2.3",
   "description": "Librería (SDK) de Javascript/NodeJS para acceder al API de Administración Tributaria Virtual (ATV) del Ministerio de Hacienda.",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

diff --git a/src/ATV/index.ts b/src/ATV/index.ts
@@ -55,27 +55,26 @@ export class ATV {
     try {
       const response = await axios(input)
       const xmlResponse = response.data['respuesta-xml']
+      const headerResultState = response.data['ind-estado']
       if (!xmlResponse) {
-        const state = response.data['ind-estado']
-        return {
-          status: response.status,
-          state,
-          errorCause: null
-        }
+        throw new Error('NO_XML_IN_RESPONSE')
       }
       const xmlString = this.decodeBase64(xmlResponse)
 
       return {
         status: response.status,
+        headerResultState,
         confirmation: this.parseConfirmationMessage(xmlString),
         xml: xmlString,
-        errorCause: null
+        rawResponse: response,
+        errorCause: null,
       }
     } catch (error) {
       const response = error.response || {}
       return {
         status: response.status || 500,
-        errorCause: response.statusText
+        errorCause: response.statusText || error.message,
+        rawResponse: response,
       }
     }
   }