Sanitize href props with xss vulnerability V2 #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tcbegley
reviewed
Feb 3, 2024
src/components/nav/NavLink.js
Outdated
| @@ -1,9 +1,11 @@ | |||
| import React, {useEffect, useState} from 'react'; | |||
| import React, {useEffect, useState, useMemo} from 'react'; | |||
There was a problem hiding this comment.
useMemo not used in this file afaict
There was a problem hiding this comment.
Right - I didn't do npm run format yet. Still lots of files to change :-)
tcbegley
force-pushed
the
fix-xss-props2
branch
from
5ad2be3
to
08e85c6
Compare
tcbegley
force-pushed
the
fix-xss-props2
branch
from
08e85c6
to
8b55738
Compare
tcbegley
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Great stuff, thanks @AnnMarieW!
I made a few small edits:
- Used
pytest.mark.parameterizeinside the integration tests, I think it makes it a little easier to see what is going on in the test + that the same check is being performed for multiple components. - Some small changes to prop destructuring, e.g. where we pull out
setPropswe no longer need to callomitand so on.
Merged
tcbegley
added a commit
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize html props that are vulnerable to xss vulnerability if user data is inserted.
This is the new version based on comments in #999
Let's keep this as a draft until plotly/dash#2743 is resolved.