Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace broken Plotly plots in widget with matplotlib #17

Merged
merged 23 commits into from
Oct 24, 2017
Merged

Replace broken Plotly plots in widget with matplotlib #17

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
32c1cb4
changed html widget to dom output widget for rendering matplotlib plots
shwinnn Oct 16, 2017
fe767e1
amended typo widget->widgets
shwinnn Oct 16, 2017
e46474f
Fixed display of matplotlib plots within output widget
shwinnn Oct 16, 2017
85e0187
Set plot size in both matplotlib figure and Output widget
zblz Oct 16, 2017
85786c2
Add plot_pairdensity_mpl method to plotting
zblz Oct 16, 2017
2a72cbe
re-enabled pairdensity plot using output widgets
shwinnn Oct 16, 2017
ddd4666
added plot_correlation_mpl to create correlation plots in matplotlib
shwinnn Oct 16, 2017
5efba7b
renamed figure, plot area and updated docstring in update_plot
shwinnn Oct 16, 2017
4767c9b
fixed correlation plot maximum width & height
shwinnn Oct 16, 2017
f18eec9
moved axis ticks & labels, inverted colour map for correlation matrix…
shwinnn Oct 16, 2017
657aef2
changed colourmap name
shwinnn Oct 16, 2017
7b3bfba
enabled correlation matrix plots to be displayed in output widgets
shwinnn Oct 16, 2017
a7d39d0
corrected plot sizing in update_plot
shwinnn Oct 16, 2017
b99b67d
fixed the cells in correlation plots to be squares
shwinnn Oct 16, 2017
dde199b
changed number display format on correlation plots
shwinnn Oct 16, 2017
76163f5
modified aspect ratio for correlation plots displayed in widget
shwinnn Oct 16, 2017
1157969
Fix alignment of bar chart in plot_distribution
zblz Oct 16, 2017
692e29b
Remove alpha for ax.bar
zblz Oct 16, 2017
28c2ce5
Formatting and order fixes
zblz Oct 16, 2017
5a14ff9
enforced PEP8 compliance
shwinnn Oct 16, 2017
074f0f8
Enforces at least version 6 of ipywidgets
shwinnn Oct 23, 2017
771e04f
Added comment explaining 'magic numbers' for enforcing plot width
shwinnn Oct 23, 2017
b95118c
Simplify correlation plot width computation
zblz Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lens/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ def plot_correlation_mpl(ls, include=None, exclude=None):

ax.xaxis.tick_top()

# Enforces a width of 2.5 inches per cell in the plot,
# unless this exceeds 600 pixels.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did that 600 pixels number come from?

As a side-note, replacing w with width_inches would be a lot clearer.

w = len(columns) * 2.5
while w > 10:
w /= np.sqrt(1.4)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pretty heavy use of magic numbers here. Why those numbers? What does this do?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just set w = 10 here?

Expand Down