Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated DataFrame.get_values with to_numpy #48

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace deprecated DataFrame.get_values with to_numpy #48

wants to merge 5 commits into from

Conversation

zblz
Copy link
Member

@zblz zblz commented Jul 1, 2020

Fixes #47

@zblz zblz requested a review from srstevenson July 1, 2020 01:02
srstevenson
srstevenson approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@srstevenson srstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

acroz
acroz approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@acroz acroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! (apart from the failing bid 😬 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acroz acroz acroz approved these changes

@srstevenson srstevenson srstevenson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pandas==1.0.1 and lens.summarize(df) throws Error
3 participants
@zblz @acroz @srstevenson