Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ep 5623 fix mongoose paginate to make filter optional #42

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Ep 5623 fix mongoose paginate to make filter optional #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
290734e
fix: add missing optional decorator
nataszczypiora Jul 3, 2024
e8cef36
test: add space
nataszczypiora Jul 3, 2024
6095b46
fix: spaces
nataszczypiora Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/input.dto.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ describe('CounterDto', () => {
const errors = await validate(counterDto);
expect(errors.length).toBe(0);
});

it('should allow payload without any filter', async () => {
const payload = {};
const counterDto = plainToClass(CounterDto, payload);
const errors = await validate(counterDto);

expect(errors.length).toBe(0);
});
});

describe('CollectionDto', () => {
Expand Down
1 change: 1 addition & 0 deletions src/input.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export class CounterDto {
type: String,
})
@Transform((v: TransformFnParams) => filterQueryToObject(v.value))
@IsOptional()
@IsObject()
readonly filter?: FilterableParameters;
}
Expand Down
Loading