-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Performance optimization for MultiProducerStrategy
* AtomicBitset bulk set/reset * Rename to Single(Multi)ProducerStrategy * Eliminate usage of reserve(), use tryReserve() instead * Remove warnings Signed-off-by: drslebedev <[email protected]>
- Loading branch information
1 parent
e6c0183
commit e5f466f
Showing
9 changed files
with
445 additions
and
255 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| #ifndef GNURADIO_ATOMICBITSET_HPP | ||
| #define GNURADIO_ATOMICBITSET_HPP | ||
|
|
||
| #include <vector> | ||
|
|
||
| #ifndef forceinline | ||
| // use this for hot-spots only <-> may bloat code size, not fit into cache and consequently slow down execution | ||
| #define forceinline inline __attribute__((always_inline)) | ||
| #endif | ||
|
|
||
| namespace gr { | ||
| /* | ||
| * `AtomicBitset` is a lock-free, thread-safe bitset. | ||
| * It allows for efficient and thread-safe manipulation of individual bits. | ||
| * For bulk set or reset atomic operation is guaranteed per individual bit (word). | ||
| */ | ||
| template<std::size_t Size = std::dynamic_extent> | ||
| class AtomicBitset { | ||
| static_assert(Size > 0, "Size must be greater than 0"); | ||
| static constexpr bool isSizeDynamic = Size == std::dynamic_extent; | ||
|
|
||
| static constexpr std::size_t _bitsPerWord = sizeof(size_t) * 8UZ; | ||
| static constexpr std::size_t _nStaticWords = isSizeDynamic ? 1UZ : (Size + _bitsPerWord - 1UZ) / _bitsPerWord; | ||
|
|
||
| // using DynamicArrayType = std::unique_ptr<std::atomic<std::size_t>[]>; | ||
| using DynamicArrayType = std::vector<std::atomic<std::size_t>>; | ||
| using StaticArrayType = std::array<std::atomic<std::size_t>, _nStaticWords>; | ||
| using ArrayType = std::conditional_t<isSizeDynamic, DynamicArrayType, StaticArrayType>; | ||
|
|
||
| std::size_t _size = Size; | ||
| ArrayType _bits; | ||
|
|
||
| public: | ||
| AtomicBitset() | ||
| requires(!isSizeDynamic) | ||
| { | ||
| for (auto& word : _bits) { | ||
| word.store(0UL, std::memory_order_relaxed); | ||
| } | ||
| } | ||
|
|
||
| explicit AtomicBitset(std::size_t size = 0UZ) | ||
| requires(isSizeDynamic) | ||
| : _size(size), _bits(std::vector<std::atomic<std::size_t>>(size)) { | ||
| // assert(size > 0UZ); | ||
| for (std::size_t i = 0; i < _size; i++) { | ||
| _bits[i].store(0UL, std::memory_order_relaxed); | ||
| } | ||
| } | ||
|
|
||
| void set(std::size_t bitPosition, bool value) { | ||
| assert(bitPosition < _size); | ||
| const std::size_t wordIndex = bitPosition / _bitsPerWord; | ||
| const std::size_t bitIndex = bitPosition % _bitsPerWord; | ||
| const std::size_t mask = 1UL << bitIndex; | ||
|
|
||
| std::size_t oldBits; | ||
| std::size_t newBits; | ||
| do { | ||
| oldBits = _bits[wordIndex].load(std::memory_order_relaxed); | ||
| newBits = value ? (oldBits | mask) : (oldBits & ~mask); | ||
| } while (!_bits[wordIndex].compare_exchange_weak(oldBits, newBits, std::memory_order_release, std::memory_order_relaxed)); | ||
| } | ||
|
|
||
| void set(std::size_t begin, std::size_t end, bool value) { | ||
| assert(begin <= end && end <= _size); // [begin, end) | ||
|
|
||
| std::size_t beginWord = begin / _bitsPerWord; | ||
| std::size_t endWord = end / _bitsPerWord; | ||
| const std::size_t beginOffset = begin % _bitsPerWord; | ||
| const std::size_t endOffset = end % _bitsPerWord; | ||
|
|
||
| if (begin == end) { | ||
| return; | ||
| } else if (beginWord == endWord) { | ||
| // the range is within a single word | ||
| setBitsInWord(beginWord, beginOffset, endOffset, value); | ||
| } else { | ||
| // leading bits in the first word | ||
| if (beginOffset != 0) { | ||
| setBitsInWord(beginWord, beginOffset, _bitsPerWord, value); | ||
| beginWord++; | ||
| } | ||
| // trailing bits in the last word | ||
| if (endOffset != 0) { | ||
| setBitsInWord(endWord, 0, endOffset, value); | ||
| } | ||
| endWord--; | ||
| // whole words in the middle | ||
| for (std::size_t wordIndex = beginWord; wordIndex <= endWord; ++wordIndex) { | ||
| setFullWord(wordIndex, value); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void set(std::size_t bitPosition) { set(bitPosition, true); } | ||
|
|
||
| void set(std::size_t begin, std::size_t end) { set(begin, end, true); } | ||
|
|
||
| void reset(std::size_t bitPosition) { set(bitPosition, false); } | ||
|
|
||
| void reset(std::size_t begin, std::size_t end) { set(begin, end, false); } | ||
|
|
||
| bool test(std::size_t bitPosition) const { | ||
| assert(bitPosition < _size); | ||
| const std::size_t wordIndex = bitPosition / _bitsPerWord; | ||
| const std::size_t bitIndex = bitPosition % _bitsPerWord; | ||
| const std::size_t mask = 1UL << bitIndex; | ||
|
|
||
| return (_bits[wordIndex].load(std::memory_order_acquire) & mask) != 0; | ||
| } | ||
|
|
||
| [[nodiscard]] constexpr std::size_t size() const { return _size; } | ||
|
|
||
| private: | ||
| void setBitsInWord(std::size_t wordIndex, std::size_t begin, std::size_t end, bool value) { | ||
| assert(begin < end && end <= _bitsPerWord); | ||
| const std::size_t mask = (end == _bitsPerWord) ? ~((1UL << begin) - 1) : ((1UL << end) - 1) & ~((1UL << begin) - 1); | ||
| std::size_t oldBits; | ||
| std::size_t newBits; | ||
| do { | ||
| oldBits = _bits[wordIndex].load(std::memory_order_relaxed); | ||
| newBits = value ? (oldBits | mask) : (oldBits & ~mask); | ||
| } while (!_bits[wordIndex].compare_exchange_weak(oldBits, newBits, std::memory_order_release, std::memory_order_relaxed)); | ||
| } | ||
|
|
||
| forceinline void setFullWord(std::size_t wordIndex, bool value) { _bits[wordIndex].store(value ? ~0UL : 0UL, std::memory_order_release); } | ||
| }; | ||
|
|
||
| } // namespace gr | ||
|
|
||
| #endif // GNURADIO_ATOMICBITSET_HPP |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.