Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Enable Plugin tests for clang and use ut #222

Merged
merged 3 commits into from
Nov 15, 2023
Merged

WIP: Enable Plugin tests for clang and use ut #222

merged 3 commits into from
Nov 15, 2023

Conversation

frankosterfeld
Copy link
Contributor

@frankosterfeld frankosterfeld commented Nov 14, 2023 •
edited
Loading

Make app_grc test a proper ut unit test and build/run them for clang. Work around issues with static lifetimes and ut (see issue #125).

@frankosterfeld frankosterfeld mentioned this pull request Nov 14, 2023
Closed
@frankosterfeld frankosterfeld linked an issue Nov 14, 2023 that may be closed by this pull request
[2pt,0.75pt] graph-prototype: Fix issues with uT and dynamic libraries, plugins #125
Closed
@frankosterfeld frankosterfeld force-pushed the frank/wip-plugin-tests-ut-clang branch from b086f51 to a024356 Compare November 14, 2023 11:49
frankosterfeld
frankosterfeld commented Nov 14, 2023
View reviewed changes
core/include/gnuradio-4.0/plugin_loader.hpp
// Try to create a node from the global registry
if (auto result = _global_registry->createBlock(name, type, params)) {
return result;
}

auto it = _handler_for_name.find(name);
auto it = _handler_for_name.find(std::string(name)); // TODO avoid std::string here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use something like in the answer here: https://stackoverflow.com/questions/34596768/stdunordered-mapfind-using-a-type-different-than-the-key-type not sure what the straight-forward way nowadays is.

@frankosterfeld frankosterfeld marked this pull request as ready for review November 14, 2023 15:30
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.6% 63.6% Coverage
0.0% 0.0% Duplication

RalphSteinhagen
RalphSteinhagen approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It seems that the original issue was solved by the new UT and/or Clang compiler version. I would leave it at this for the time being. We could re-open this if this reoccurs.

@RalphSteinhagen RalphSteinhagen merged commit e68977e into main Nov 15, 2023
@RalphSteinhagen RalphSteinhagen deleted the frank/wip-plugin-tests-ut-clang branch November 15, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt,0.75pt] graph-prototype: Fix issues with uT and dynamic libraries, plugins
2 participants
@frankosterfeld @RalphSteinhagen