Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestBackend: Do not expire connections that are in use #344

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

frankosterfeld
Copy link
Contributor

Actually update the "lastUsed" timestamp when accessing a cached connection. Otherwise the cache is destroyed and recreated in normal operation, leading to LongPollingIdx=Next requests to fail (as they were redirected to the latest index before cache reset, which is then considered a "future" index, as the latest index is reset to 0).

Actually update the "lastUsed" timestamp when accessing a cached
connection. Otherwise the cache is destroyed and recreated in normal
operation, leading to LongPollingIdx=Next requests to fail (as they
were redirected to the latest index before cache reset, which is then
considered a "future" index, as the latest index is reset to 0).
@frankosterfeld frankosterfeld force-pushed the frank/restbackend-fix-connection-timeout branch from 3bfa375 to ccbd978 Compare March 13, 2024 16:24
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.03%. Comparing base (09cc4c9) to head (3bfa375).

❗ Current head 3bfa375 differs from pull request most recent head ccbd978. Consider uploading reports for the commit ccbd978 to get more accurate results

Files Patch % Lines
src/majordomo/include/majordomo/RestBackend.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   57.02%   57.03%           
=======================================
  Files          69       69           
  Lines        7360     7361    +1     
  Branches     2728     2728           
=======================================
+ Hits         4197     4198    +1     
  Misses       1325     1325           
  Partials     1838     1838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@RalphSteinhagen RalphSteinhagen merged commit c7236c4 into main Mar 13, 2024
8 of 9 checks passed
@RalphSteinhagen RalphSteinhagen deleted the frank/restbackend-fix-connection-timeout branch March 13, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants