Working subscription #240

wirew0rm · 2024-11-12T18:01:49Z

~~Draft due to fair-acc/opencmw-cpp#358 not yet being merged and some opinionated changes.~~

See the individual commit messages for more information on the changes.

The goal of this branch is to allow to reliably subscribe to a service.
To that end it changes the RemoteSource to do proper state management and reconnect in case of subscription errors.

Also this adds more diagnostics with counters, tags, printouts and a small cli tool to analyze the total latency of the processing and networking stack.

The current state will still accumulate some latency for update rates higher than ~5Hz on my system and will need further improvements, but it should be enough to build upon while we try to follow up these issues further.

github-actions · 2024-11-12T18:50:47Z

PR produced different images:

chart_0001.png

Got:

Expected:

Diff:

wirew0rm · 2024-11-14T11:08:28Z

Have to change RemoteSource and Scheduler handling to do all emscripten_fetch handling in the worker thread, control the scheduler state via messages and use emscripten_sleep() to process results in the worker threads.

src/acquisition/daq_api.hpp

src/service/gnuradio/GnuRadioAcquisitionWorker.hpp

src/service/main.cpp

src/ui/App.hpp

src/ui/blocks/RemoteSource.hpp

RalphSteinhagen

Looks good and saw that it locally fixes the subscription drop/reconnect. Well done. 👍

There are a still a lot of verbose debugging print-outs which should be sanitized as they obfuscate unrelated debugging.

Depending on the local/specific case, I'd recommend either via:

removing them entirely. If someone needs it again, they can always re-added later. Leaving them in means someone else is paying the price for reading/cleaning-up.
for critical info/warning messages, convert them to, for example:
- UI: popup info/warning/error messages
- GR: throw an exception that is intercepted and forwarded by the calling block to the scheduler (and eventually UI) or send an explicit message via the Block's msg port
add a block-local circular history buffer that can be displayed/inspected during runtime.

The required changes are minor and do not require further review. Feel free to merge once the changes are in and the CI has passed.

Signed-off-by: Alexander Krimm <[email protected]>

change sampling rate to 10KS/s and remove unused parameter Signed-off-by: Alexander Krimm <[email protected]>

Signed-off-by: Alexander Krimm <[email protected]>

Needs gnuradio4 headers due to tag definitions being used. Signed-off-by: Alexander Krimm <[email protected]>

This is required for the emscripten fetch calls to be issued in the main browser thread. If they are issued on another thread, they are only processed once the thread is finished. Otherwise we would have to investigate if there is a way to control on which thread the callbacks should be processed or we would have to proxy the emscripten_fetch calls to the main thread. This is further complicated because it needs to be transparent to the part of the code that also compiles to native. Set graph threadpool size to one Signed-off-by: Alexander Krimm <[email protected]>

Moves setting up the subscription to the start and stop methods instead of performing them on settings change, which lead to duplicate subscriptions. Also fixes a bug that would not actually perform any unsubscribes making the subscriptions live on forever. Also introduces propagation of Timing Events. Signed-off-by: Alexander Krimm <[email protected]>

wirew0rm force-pushed the workingSubscription branch 2 times, most recently from 124a900 to 7e89e9f Compare November 13, 2024 20:42

wirew0rm marked this pull request as ready for review November 14, 2024 09:50

wirew0rm marked this pull request as draft November 14, 2024 11:05

wirew0rm force-pushed the workingSubscription branch from 7e89e9f to 69f3599 Compare November 15, 2024 12:20