Remove eval
when asking user for confirmation to delete existing directories
#20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm not sure the use of
eval
here is accomplishing exactly what you want it to. Sinceeval
is directly evaluating whatever python code a user gives you, and you are then assigning that directly to the value of a variable, that means the user has to give a valid Python expression that evaluates to "something storable".For example, if a user were to just give a
Y
orN
rather than the literal"Y"
with the quotes, something like this would happen:because now Python is trying to evaluate what the literal python code
y
means.input()
should already take care of converting user input to a Python string, so I think it should be safe to simply use the value returned byinput()
It's very possible that I'm misunderstanding your intentions, so please feel free to close this PR if this behavior is intended.