Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ly on ARM64 doesn't detect any session other than shell and xinitrc #417

Closed
marco-04 opened this issue Aug 6, 2022 · 12 comments
Closed
Labels
bug This issue or pull request discusses a bug

Comments

@marco-04
Copy link

marco-04 commented Aug 6, 2022

I compiled ly both on Arch and Debian (testing) ARM64 VMs, and contrarily to other display managers, like gdm, it didn't detect the session files residing in the "/usr/share/xsessions" directory. I tried with both Gnome and XFCE

@AnErrupTion AnErrupTion added the bug This issue or pull request discusses a bug label Aug 12, 2022
@marco-04
Copy link
Author

marco-04 commented Oct 2, 2022

Yeah, I have the same problem on Asahi Linux with a recursive clone

@AnErrupTion
Copy link
Collaborator

@marco-04 There is an xsessions option in the configuration file, did you try it?

@marco-04
Copy link
Author

marco-04 commented Dec 8, 2022

I probably did when I first tried it, but I can't confirm because now I can't even launch it anymore on Asahi, as it just crashes

@AnErrupTion
Copy link
Collaborator

Ah, could you try now please? There was a slight mistake in the repo that's now fixed :D @marco-04

@marco-04
Copy link
Author

marco-04 commented Dec 8, 2022

Just tried, and it doesn't work unfortunately. The same thing happens also for wayland sessions with those options uncommented from the /etc/ly/config.ini file

@PaddiM8
Copy link

PaddiM8 commented Dec 9, 2022

I'm experiencing the same thing, on aarch64

@PaddiM8
Copy link

PaddiM8 commented Dec 16, 2022

I experimented a bit and managed to get it to retrieve the sessions and could successfully start sway. Not sure if it breaks anything else, but... I added the following to configator.c in the configator submodule:

if (disc < 0) {
    i = 0;
}

on line 45.

The data seemed to be retrieved correctly, but the configator search function ended up only looking at index 1 when the length was 2. I don't know if this is a good fix, it just happened to make it work for me. I have basically no experience with C...

@lucidph3nx
Copy link

I can confirm that the solution by @PaddiM8 works with Asahi on M1 Mac booting a sway wayland session.

@mellowgeekcc
Copy link

Yes, the solution also works on Raspberry 4 booting Xorg sessions.

@praxis88
Copy link

can confirm this works on arch/manjaro arm

@nougatbyte
Copy link

This also fixes session selection on Raspberry Pi CM4 (bookworm/arm64)

@AnErrupTion
Copy link
Collaborator

I'm marking this issue as fixed for the Zig rewrite, since it doesn't use configator anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request discusses a bug
Projects
None yet
Development

No branches or pull requests

7 participants