Zig rewrite (finally) #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What needs to be dealt with: - Matrix animation - Authentication part - Testing on actual TTY (not just virtual console) Signed-off-by: AnErrupTion <[email protected]>
|
I've committed an unfinished full rewrite into Zig that I've been holding off for a while. I'm aiming for a v1.0.0 release: |
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
* Everything * make matrix.zig a bit cleaner * make long lines shorter and add changelog * vi mode * update changelog * get errors from child process and (hopefully) fix some other things * fix utmp entry * run authentication in a child process * update changelog * small code improvements * change that * clear terminal on SIGTERM * Remove LogFile * moved ini to a lib, fixed alternative langs * fix logging out * oops * code improvements * consistency * clearing the env isn't needed anymore (afaik) * replace vi_mode with a bool * type aliases, avoiding zeroes(), breaking a long line * lowercase insert/normal, merge conditionals, code improvements
…suffix Signed-off-by: AnErrupTion <[email protected]>
|
Good news everyone! The rewrite should be ready fairly soon as it now works. We're ironing out the last few bugs and missing features, as well as preparing the list of closed issues and PRs. |
Signed-off-by: AnErrupTion <[email protected]>
This was
linked to
issues
Apr 16, 2024
Closed
This was
linked to
issues
Apr 16, 2024
* clean up child processes on SIGTERM * small code improvement * consistency.. i guess?
Signed-off-by: AnErrupTion <[email protected]>
* less alloc, update migrator, get DesktopNames from .desktop * small cleanup * Update zigini to improve compatibility with old config * Code improvements * Update to zig version 0.12.0 * Some fixes * tiny changes * remove useless comment * migrator changes, and small things * set XDG env vars differently * free memory on error when appending environments
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
* fix loginConv and auth * fix potential mem leak with configs * BIG changes
|
I was also put of from making some contributions since the C code was difficult to comprehend for me. I will try again with zig, as it gives me more confidence :) (if I find the time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
As you may have noticed for quite a while now, Ly hasn't been a very active project (most that is done is maintenance with light bug fixing here and there). Well, I want to change that.
I'm not very comfortable with C/C++. So I've decided to rewrite Ly into Zig, a language I'm much more comfortable with. This originally came off as a progressive rewrite, however I deemed that this was not the most optimal solution, and thus followed by a full rewrite into "idiomatic" Zig.
Considering I haven't gotten much news from @nullgemm recently (if at all), I believe he doesn't have a lot of time to work on his projects. Thus, I'm taking the initiative, but feel free to stop me.EDIT: He seemed fine for the project to move to Zig, so I'm concluding I can proceed.
What's the point of this? Mostly to make myself more familiar with the code (even though it's small and tidy, as I said, I'm not very comfortable with C/C++), and to potentially reduce the code size a bit as well. This will, I hope, make it easier (for me at least) to fix bugs and to add new features.
For now, this PR will be a draft until the last things are dealt with (see the description of commit 92e1f08). I'm personally very excited about this, and I hope you are too!