-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Apple Silicon #58
Conversation
Also fixes issue where xcframework cannot be made if more than one arch for macOS is used Closes faithfracture#57
Eek. Sorry @Deadpikle, missed this. Everything still applicable post-Xcode 12 GM / Release? |
No problem. I need to check -- I've not downloaded the Xcode 12 release yet. I'll have to get back to you. :) |
…-BuildScript into feature/silicon
@faithfracture Sorry, no, GM for Xcode 12 doesn't include universal binary support. There's a note on the download page: "For development on macOS Big Sur or to support Apple silicon, continue to use Xcode 12 beta 6." So, let's keep this PR in frozen mode until there's an official version of Xcode with silicon support -- which I'm guessing will come when Big Sur comes out -- or closer to that time? Then I'll take a look at this again. |
Bah, of course. Ok, sounds good to me! |
@faithfracture Xcode 12.2 came out today. With it comes universal binary building and thus this PR now works! Sample command:
Outputs: @Anil8753 I don't know, sorry. It would require more investigation on my part, and since I don't need it for work, I don't have time for that right now. |
@Deadpikle Would you mind resolving the merge conflicts? I don't use Catalyst or Silicon currently and I don't want to screw up what you've done. |
Sure. Will get to it next week if I can. |
@faithfracture Should be good to go assuming the CI finishes successfully. Did a quick test of the sample app and it seemed to work ok for iOS Catalyst and macOS. Still don't have a silicon device to test on, though. :( Edit: Had to update the CI script to use the latest, stable Xcode so that Xcode 12.2 was used. |
Looks like CI is passing just fine 🥳 @faithfracture Ready for you whenever you are able to take a look. |
This PR adds support for Apple Silicon!
This PR also fixes an issue where the
xcframework
file cannot be made if more than one arch for macOS is used (e.g. i386 with x86_64).Closes #57