Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(ci): run against playground #3095

Open
wants to merge 28 commits into
base: next
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"type": "module",
"main": "dist/index.cjs",
"module": "dist/index.js",
"types": "index.d.ts",
mshima marked this conversation as resolved.
Show resolved Hide resolved
"types": "dist/types/index.d.ts",
"typesVersions": {
">=5.0": {
"*": [
Expand Down
3 changes: 0 additions & 3 deletions test/faker.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@
);
});

it('should not log anything on startup', async () => {

Check failure on line 16 in test/faker.spec.ts

View workflow job for this annotation

GitHub Actions / Lint: node-22, ubuntu-latest

Async arrow function has no 'await' expression
const spies: MockInstance[] = keys(console)
.filter((key) => typeof console[key] === 'function')
.map((methodName) => vi.spyOn(console, methodName));

const file: unknown = await import('..');
expect(file).toBeDefined();

mshima marked this conversation as resolved.
Show resolved Hide resolved
new Faker({ locale: { metadata: { title: '' } } });

for (const spy of spies) {
Expand Down
Loading