Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing example return value for internet.jwt #3286

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

See title 😄

Originally found by @xDivisionByZerox in #3284 (comment)

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: internet Something is referring to the internet module labels Nov 26, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team November 26, 2024 20:57
@xDivisionByZerox xDivisionByZerox self-assigned this Nov 26, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner November 26, 2024 20:57
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 5b7e2a7
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6746362f1afb8100080d38f4
😎 Deploy Preview https://deploy-preview-3286.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (b390432) to head (5b7e2a7).
Report is 3 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3286      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217157   217157              
  Branches      982      977       -5     
==========================================
- Hits       217088   217084       -4     
- Misses         69       73       +4     
Files with missing lines Coverage Δ
src/modules/internet/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Nov 26, 2024
@ST-DDT ST-DDT requested a review from a team November 26, 2024 21:03
@ST-DDT ST-DDT added this pull request to the merge queue Nov 30, 2024
Merged via the queue into next with commit d09aed0 Nov 30, 2024
26 checks passed
@ST-DDT ST-DDT deleted the docs/add-missing-example-return-value-for-jwt branch November 30, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: internet Something is referring to the internet module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants