Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve example output for replaceSymbols #3304

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

matthewmayer
Copy link
Contributor

found while testing #3301

@matthewmayer matthewmayer requested a review from a team as a code owner December 1, 2024 17:19
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e905bb1
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/674c9aae1323ac0008eba988
😎 Deploy Preview https://deploy-preview-3304.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (01e20e9) to head (e905bb1).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3304      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217140   217140              
  Branches      977      978       +1     
==========================================
- Hits       217074   217062      -12     
- Misses         66       78      +12     
Files with missing lines Coverage Δ
src/modules/helpers/index.ts 96.71% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team December 1, 2024 17:22
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels Dec 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 1, 2024
@ST-DDT ST-DDT added this pull request to the merge queue Dec 2, 2024
Merged via the queue into faker-js:next with commit 4e4c79d Dec 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants