feat(finance): add ISO 4217 numerical codes to Currency object #3404
+465
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added numID parameter to currency object in all languages (put zero for all non ISO currency (cypto currency)). added currencyNumID to finance definition. added currencyNumID testing to finance.spec.ts changed descriptions to match new parameter. added random currencyNumID method
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3404 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 2811 2811
Lines 216972 217398 +426
Branches 943 941 -2
========================================
+ Hits 216919 217345 +426
Misses 53 53
|
ST-DDT
added
c: feature
ST-DDT
reviewed
Feb 17, 2025
Changed previous parameter numID --> numericCode. Changed comments to reflect change and newest release.
Changed parameter numID --> numericCode
Changed parameter numID --> numericCode
Changed parameter numID --> numericCode. Removed comment dev artifacts.
Changed parameter numID --> numericCode. Removed dev artifact comments
Changed parameter numID --> numericCode. Removed dev artifact comments.
Changed comment from numID to numericCode
Updated to new numericCode naming (numID previous)
Changed parameter numID --> numericCode Changed method currencyNumID --> currencyNumericCode
Changed method currencyNumID --> currencyNumericCode
ST-DDT
reviewed
Feb 17, 2025
ST-DDT
changed the title
chore(deps): lock file maintenance (faker-js#3403)
finance object parameter numericCode has been updated to a string. numericCode has been given significant zeros. (e.g. '8' -> '008')
fix: test before using Buffers (faker-js#3400)
|
Should I update my original pull request description to fit the new parameter names? |
ST-DDT
reviewed
Feb 19, 2025
add grave markers around numerical code description. Co-authored-by: ST-DDT <[email protected]>
change numerical ID to numeric code in description. Co-authored-by: ST-DDT <[email protected]>
change number ID to numeric code in description. Co-authored-by: ST-DDT <[email protected]>
fa language file was overridden by zh_CHN langauge file, changes reverted back to original.
| it('should return a string', () => { | ||
| const currencyNumericCode = faker.finance.currencyNumericCode(); | ||
|
|
||
| expect(currencyNumericCode).toBeTypeOf('string'); |
There was a problem hiding this comment.
also check its 3 characters long?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #2289
added numericCode parameter to currency object in all languages (put zero for all non ISO currency (cypto currency)).
added currencyNumericCode to finance definition.
added currencyNumericCode testing to finance.spec.ts
changed descriptions to match new parameter.
added random currencyNumericCode method.