Skip to content

types(date): allow Date obj as argument #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

types(date): allow Date obj as argument #483

wants to merge 1 commit into from

Conversation

@fratzinger
Copy link

All methods in faker.date only allowed the type string but tests were also run with Date arguments. So passing a Date was possible but resulted in a TS error. This PR allows Date as argument for all relevant faker.date methods.

@fratzinger fratzinger requested a review from a team as a code owner February 13, 2022 14:47
@fratzinger
Copy link
Author

saw #200 too late. Closing this in favor of #200.

@fratzinger fratzinger closed this Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fratzinger @Shinigami92