feat(agent): return SerializationError instead of aborting #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
from
ef30ef9 to
8b4e8af
Compare
efiop
force-pushed
the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
from
8b4e8af to
d43e6f8
Compare
efiop
changed the title
|
Testing with unreleased version is hell in fal-isolate-cloud (e.g. poetry seems to be having troubles with dependency resolution when updating the lock), so I'll just crank out a new release here (we lock particular version everywhere, so shouldn't be an issue). |
efiop
changed the title
efiop
deleted the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
efiop
added a commit
that referenced
this pull request
May 21, 2024
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
added a commit
that referenced
this pull request
May 22, 2024
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
added a commit
that referenced
this pull request
May 22, 2024
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
added a commit
that referenced
this pull request
May 23, 2024
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
added a commit
that referenced
this pull request
May 23, 2024
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
added a commit
that referenced
this pull request
May 23, 2024
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
added a commit
that referenced
this pull request
May 23, 2024
* fix(agent): use context.abort() instead of returning We stopped always yielding stuff unconditionally, so now if you get an error and use our own `abort_with_msg` we'll get an error iterating responses, as we never yield anything and just return `None`. So instead just use proper grpc `ServicerContext.abort()` method to raise an exception instead. * fix(agent): log exception instead of returning (revert #121) We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing we let the
SerializationErrorgo straight to the user and we should do the same on deserializing instead of returning a grpc error.