Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conda): use --yes instead of --force #123

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Apr 27, 2024

A few days ago conda 24.3.0 removed --force completely causing this to no longer work. --yes has been around for more than a year now and we don't really need to support old conda/miniconda so we can just directly replace it and not bother with compatibility with older versions.

https://github.com/conda/conda/releases/tag/24.3.0

Discovered in https://github.com/fal-ai/isolate-cloud/pull/1676 and blocking it.

A few days ago conda 24.3.0 removed `--force` completely causing this
to no longer work. `--yes` has been around for more than a year now
and we don't really need to support old conda/miniconda so we can just
directly replace it and not bother with compatibility with older versions.

https://github.com/conda/conda/releases/tag/24.3.0
Copy link

linear bot commented Apr 27, 2024

@efiop efiop merged commit b6094f6 into main Apr 27, 2024
6 checks passed
@efiop efiop deleted the ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully branch April 27, 2024 01:53
efiop added a commit that referenced this pull request May 23, 2024
A few days ago conda 24.3.0 removed `--force` completely causing this
to no longer work. `--yes` has been around for more than a year now
and we don't really need to support old conda/miniconda so we can just
directly replace it and not bother with compatibility with older versions.

https://github.com/conda/conda/releases/tag/24.3.0
efiop added a commit that referenced this pull request May 24, 2024
….7 (#136)

* chore: revert to v0.12.7

* build: add cloudpickle to agent requirements (#118)

* chore: drop python 3.7 and use ruff/poetry-check/pyupgrade (#119)

* lint: use ruff

* chore: add poetry-check to pre-commit

* chore: drop python 3.7

* chore: add pre-commit to gha

* chore: run tests on schedule

* chore: only test 3.8 and 3.11 on macos

* fix(test): readlinks for python before comparing

* fix(conda): use --yes instead of --force (#123)

A few days ago conda 24.3.0 removed `--force` completely causing this
to no longer work. `--yes` has been around for more than a year now
and we don't really need to support old conda/miniconda so we can just
directly replace it and not bother with compatibility with older versions.

https://github.com/conda/conda/releases/tag/24.3.0

* chore: revisit build/test/release process (#126)

* chore: use setuptools instead of poetry

* chore: introduce dev extra

* chore(gha): revisit release process

* chore: activate more ruff rules

* chore: delete cliff.toml (#127)

No longer used.

* feat(backend): Add container backend (#135)

---------

Co-authored-by: Kemal Akkoyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant