-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use directory-mapping instead of simple containerd.socket-file-mapping #633
Conversation
Welcome @devfaz! It looks like this is your first PR to falcosecurity/charts 🎉 |
Hi @devfaz, thank you for the PR! Could you please update the docs by running |
run |
Running diff --git a/charts/falco/README.md b/charts/falco/README.md
index e83c3f5..81ecd66 100644
--- a/charts/falco/README.md
+++ b/charts/falco/README.md
@@ -581,7 +581,7 @@ If you use a Proxy in your cluster, the requests between `Falco` and `Falcosidek
## Configuration
-The following table lists the main configurable parameters of the falco chart v4.2.2 and their default values. See [values.yaml](./values.yaml) for full list.
+The following table lists the main configurable parameters of the falco chart v4.2.3 and their default values. See [values.yaml](./values.yaml) for full list.
|
im using podman, so had to adapt the Makefile a bit to get it working. Just a FYI in case someone googles this later.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale |
@devfaz, do you plan to update this PR by any chance? |
@alacuku I already did? Do you miss anything? |
You need to rebase and resolve the conflicts. |
to allow falco to reconnect if containerd got restarted on host Fixes falcosecurity#632 Signed-off-by: Fabian Zimmermann <[email protected]>
Done, sorry havnt seen it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a1483f69a6ffb4fef0da57099b2b45a9d9a44a6f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, devfaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #632
Special notes for your reviewer:
to allow falco to reconnect if containerd got restarted on host
Checklist