Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falco/helpers): adjust formatting to be compatible with older helm versions #636

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Mar 8, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

The way a helper was formatted caused errors with older helm versions. I tested helm v3.0.0 and it failed to process the falco chart. This PR changes the formatting to fix the issue.

Which issue(s) this PR fixes:

Fixes #635

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falco-chart labels Mar 8, 2024
@poiana poiana requested review from bencer and leogr March 8, 2024 08:46
@poiana poiana added the size/S label Mar 8, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@poiana poiana added the lgtm label Mar 8, 2024
@poiana
Copy link
Contributor

poiana commented Mar 8, 2024

LGTM label has been added.

Git tree hash: 20c7cdee8360749a88f5a188d82fe6e98fd4efa5

@poiana
Copy link
Contributor

poiana commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Mar 8, 2024
@poiana poiana merged commit 34f7db6 into falcosecurity:master Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falco-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: parse error at (falco/templates/_helpers.tpl:406): unclosed action
3 participants