[falcosidekick] fix: component label in matchers for servicemonitor #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Berreis <[email protected]>
Signed-off-by: Thomas Berreis <[email protected]>
Signed-off-by: Thomas Berreis <[email protected]>
poiana
added
kind/bug
Issif
approved these changes
Mar 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, tberreis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 5d1c6e47a80912a4bc6576d04776cb897c94c7ef
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
Adds component label to ServiceMonitor to scrape falcosidekick containers only and not the UI which produces 404 http responses
Which issue(s) this PR fixes:
Update to #626 where the label was added in the wrong file and produces kubeconform errors #634.
Special notes for your reviewer:
Checklist