Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump falcosidekick version in falco chart dependency #638

Merged
merged 2 commits into from
Mar 12, 2024
Merged

bump falcosidekick version in falco chart dependency #638

merged 2 commits into from
Mar 12, 2024

Conversation

OMGRaresh
Copy link

What type of PR is this?
/kind bug
/kind chart-release

Any specific area of the project related to this PR?
/area falco-chart

What this PR does / why we need it:
Installing falcosidekick through the falco helm chart falcosidekick.enabled: true is not using the latest falcosidekick version. The installed version has a bug, which is fixed in this PR.

Which issue(s) this PR fixes:
PR

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • CHANGELOG.md updated

@poiana poiana added dco-signoff: no kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped area/falco-chart labels Mar 12, 2024
@poiana poiana requested a review from alacuku March 12, 2024 10:15
@poiana
Copy link
Contributor

poiana commented Mar 12, 2024

Welcome @OMGRaresh! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested a review from bencer March 12, 2024 10:15
@poiana poiana added the size/S label Mar 12, 2024
@OMGRaresh OMGRaresh changed the title bump falcosidekick verion in falco chart dependency bump falcosidekick version in falco chart dependency Mar 12, 2024
charts/falco/CHANGELOG.md Outdated Show resolved Hide resolved
@poiana
Copy link
Contributor

poiana commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, OMGRaresh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Mar 12, 2024

LGTM label has been added.

Git tree hash: 8ce13432adaf055610c47178673a4ae8fd36f34c

@poiana poiana merged commit 73f17ba into falcosecurity:master Mar 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falco-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants