update(falco): add HOST_ROOT and FALCO_HOSTNAME by default
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
leogr
force-pushed
the
chore/env/host-and-hostname
branch
from
7bbe1a0
to
3ef3c28
Compare
This env var is consumed by Falco's gRPC servers and passed to libs to populate `evt.hostname`, and used in metrics (possibly other purpose in the future) as well. Signed-off-by: Leonardo Grasso <[email protected]>
Although HOST_ROOT is already set in all container images consumed by this chart, its default value (i.e. `/host`) is hard-coded in many points across this chart. So for consistency, we also force set it in `env:` for the main container and the initContainer as well. The alternative would be to make it parametric, but since this is just an implementation detail that does not produce a user-facing effect, there's no compelling reason for the user to modify it. Moreover, the hard-coded value works since its usage is consistent across and limited to only containers managed by this chart. Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
chore/env/host-and-hostname
branch
from
3ef3c28
to
3f4b245
Compare
|
rebased /unhold |
alacuku
approved these changes
Apr 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, cpanato, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes falcosecurity/deploy-kubernetes#95
Special notes for your reviewer:
/hold for double checking and second opinions
cc @falcosecurity/core-maintainers
Checklist