Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(falco): add HOST_ROOT and FALCO_HOSTNAME by default #644

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 26, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes falcosecurity/deploy-kubernetes#95

Special notes for your reviewer:

/hold for double checking and second opinions
cc @falcosecurity/core-maintainers

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request do-not-merge/hold dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped labels Mar 26, 2024
@poiana poiana requested review from alacuku and bencer March 26, 2024 16:24
cpanato
cpanato previously approved these changes Mar 26, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

alacuku
alacuku previously approved these changes Mar 27, 2024
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

This env var is consumed by Falco's gRPC servers and passed to libs to populate `evt.hostname`, and used in metrics (possibly other purpose in the future) as well.

Signed-off-by: Leonardo Grasso <[email protected]>
Although HOST_ROOT is already set in all container images consumed by this chart, its default value (i.e. `/host`) is hard-coded in many points across this chart. So for consistency, we also force set it in `env:` for the main container and the initContainer as well.

The alternative would be to make it parametric, but since this is just an implementation detail that does not produce a user-facing effect, there's no compelling reason for the user to modify it.  Moreover, the hard-coded value works since its usage is consistent across and limited to only containers managed by this chart.

Signed-off-by: Leonardo Grasso <[email protected]>
@leogr
Copy link
Member Author

leogr commented Apr 12, 2024

rebased

/unhold

@poiana
Copy link
Contributor

poiana commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, cpanato, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alacuku,cpanato,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8653678 into master Apr 12, 2024
6 checks passed
@poiana poiana deleted the chore/env/host-and-hostname branch April 12, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falco-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kubernetes configs - will fix a few things
4 participants