Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: docs(OWNERS): add alacuku (Aldo Lacuku) to approvers #646

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Mar 28, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Proposing myself as falcoctl maintainer as per 2024-03-27 community call discussion.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/hold until a week has passed or the majority is reached (as per our governance)
Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added do-not-merge/hold dco-signoff: yes kind/documentation Improvements or additions to documentation labels Mar 28, 2024
@poiana poiana requested review from bencer and Issif March 28, 2024 09:03
@poiana poiana added the size/XS label Mar 28, 2024
@Issif
Copy link
Member

Issif commented Mar 28, 2024

+1 for me 👍

@leogr
Copy link
Member

leogr commented Mar 28, 2024

+1 for me, too! 🥳

@cpanato
Copy link
Member

cpanato commented Mar 29, 2024

+1

@leogr
Copy link
Member

leogr commented Apr 3, 2024

Welcome onboard :)
/unhold

@poiana poiana added the lgtm label Apr 3, 2024
@poiana
Copy link
Contributor

poiana commented Apr 3, 2024

LGTM label has been added.

Git tree hash: c2c005d4165cb523ec26830ebe53a198677ac6f2

@poiana poiana added the approved label Apr 3, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, cpanato, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 91bfff2 into falcosecurity:master Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants