Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated grafana dashboard #657

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

dotdc
Copy link
Contributor

@dotdc dotdc commented Apr 17, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-exporter-chart

What this PR does / why we need it:

Updated the Falco Grafana dashboard ito make it more user friendly and removed deprecated panels since Grafana 7 (2020).
All details in #656

Which issue(s) this PR fixes:

Fixes #656

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added dco-signoff: yes kind/feature New feature or request kind/chart-release Add this label when the chart version has been bumped area/falco-exporter-chart labels Apr 17, 2024
@poiana poiana requested review from alacuku and bencer April 17, 2024 21:14
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard seems good to me, I just can't explain we have commentary in some of the expressions. See my comments. Once removed, I'll approve it.

charts/falco-exporter/templates/grafana-dashboard.yaml Outdated Show resolved Hide resolved
charts/falco-exporter/templates/grafana-dashboard.yaml Outdated Show resolved Hide resolved
@dotdc
Copy link
Contributor Author

dotdc commented Apr 26, 2024

The dashboard seems good to me, I just can't explain we have commentary in some of the expressions. See my comments. Once removed, I'll approve it.

Yes, this was debug data, should be all good now.

Issif
Issif previously approved these changes Apr 30, 2024
@poiana poiana added the lgtm label Apr 30, 2024
@poiana
Copy link
Contributor

poiana commented Apr 30, 2024

LGTM label has been added.

Git tree hash: f3044fdc7114451dbb3afe7c8122f43fe376ce16

@Issif
Copy link
Member

Issif commented Apr 30, 2024

Please resolve the conflicts.

@dotdc
Copy link
Contributor Author

dotdc commented Apr 30, 2024

@Issif done

@poiana poiana added the lgtm label Apr 30, 2024
@poiana
Copy link
Contributor

poiana commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dotdc, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 30, 2024

LGTM label has been added.

Git tree hash: 54d99ae8e036c271237757cd44f80578a16eea12

@poiana poiana merged commit 1275639 into falcosecurity:master Apr 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falco-exporter-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falco Events dashboard enhancements
3 participants