-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated grafana dashboard #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dashboard seems good to me, I just can't explain we have commentary in some of the expressions. See my comments. Once removed, I'll approve it.
Yes, this was debug data, should be all good now. |
LGTM label has been added. Git tree hash: f3044fdc7114451dbb3afe7c8122f43fe376ce16
|
Please resolve the conflicts. |
Signed-off-by: David Calvert <[email protected]>
@Issif done |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dotdc, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 54d99ae8e036c271237757cd44f80578a16eea12
|
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falco-exporter-chart
What this PR does / why we need it:
Updated the Falco Grafana dashboard ito make it more user friendly and removed deprecated panels since Grafana 7 (2020).
All details in #656
Which issue(s) this PR fixes:
Fixes #656
Special notes for your reviewer:
Checklist