feat : falcosidekick service monitor update add aditionnal properties #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaud CHATELAIN <[email protected]>
poiana
added
kind/feature
Issif
requested changes
May 21, 2024
charts/falcosidekick/README.md
Outdated
| @@ -574,6 +574,7 @@ The following table lists the main configurable parameters of the Falcosidekick | |||
| | service.port | int | `2801` | Service port | | |||
| | service.type | string | `"ClusterIP"` | Service type | | |||
| | serviceMonitor.additionalLabels | object | `{}` | specify Additional labels to be added on the Service Monitor. | | |||
| | serviceMonitor.additionalProperties | object | `{}` | aditionalProperties allows setting additional properties on the endpoint such as relabelings, metricRelabelings etc. | | |||
There was a problem hiding this comment.
Suggested change
| | serviceMonitor.additionalProperties | object | `{}` | aditionalProperties allows setting additional properties on the endpoint such as relabelings, metricRelabelings etc. | | |
| | serviceMonitor.additionalProperties | object | `{}` | allow setting additional properties on the endpoint such as relabelings, metricRelabelings etc. | |
Signed-off-by: Arnaud CHATELAIN <[email protected]>
…s and Fix prometheus rules Signed-off-by: Arnaud CHATELAIN <[email protected]>
Issif
reviewed
May 21, 2024
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: ArnaudCHT <[email protected]>
Issif
approved these changes
May 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArnaudCHT, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 879fb4e853ab9a745da22a6a9679084717753fc0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I run a helm template, helm lint helm dry-run to test and try the serviceMonitor on Openshift cluster. Test the prometheusRule on grafana.
Checklist