Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'for' configurable for falco exporter prometheus rules #707

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Make 'for' configurable for falco exporter prometheus rules #707

merged 1 commit into from
Jul 11, 2024

Conversation

jochbru
Copy link
Contributor

@jochbru jochbru commented Jul 9, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area falco-exporter-chart

What this PR does / why we need it:

This PR makes the for field configurable within the helm values.

Which issue(s) this PR fixes:

N/a

@poiana
Copy link
Contributor

poiana commented Jul 9, 2024

Welcome @TheChef23! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana requested review from bencer and Issif July 9, 2024 15:23
@poiana poiana added the size/S label Jul 9, 2024
@Issif
Copy link
Member

Issif commented Jul 10, 2024

Hi,

to have a valid PR, you have to update the changelog, bump up the chart version and run make docs-falco-exporter.

Warning

The falco-exporter will be deprecated in the next months, Falco now exposes a metrics endpoint

@jochbru
Copy link
Contributor Author

jochbru commented Jul 11, 2024

Hi,

to have a valid PR, you have to update the changelog, bump up the chart version and run make docs-falco-exporter.

Warning

The falco-exporter will be deprecated in the next months, Falco now exposes a metrics endpoint

Hi,

I've run the make command and bumped the version.

Issif
Issif reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the changelog please.

@jochbru
Copy link
Contributor Author

jochbru commented Jul 11, 2024

Excusez moi, fixed.

@jochbru jochbru requested a review from Issif July 11, 2024 10:57
Issif
Issif reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last point, could you rebase on master and squash your commits please

@Issif Issif self-assigned this Jul 11, 2024
@jochbru @Issif
Make 'for' configurable for falco exporter prometheus rules
4a4971d 
Signed-off-by: Jochem <[email protected]>

Bump chart version and run helm docs

Signed-off-by: Jochem <[email protected]>

Update changelog

Signed-off-by: Jochem <[email protected]>

Update charts/falco-exporter/CHANGELOG.md

Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Jochem <[email protected]>
@jochbru
Copy link
Contributor Author

jochbru commented Jul 11, 2024

Last point, could you rebase on master and squash your commits please

Done, thanks for your patience!

@jochbru jochbru requested a review from Issif July 11, 2024 11:49
@poiana poiana added the lgtm label Jul 11, 2024
@poiana
Copy link
Contributor

poiana commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, TheChef23

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jul 11, 2024

LGTM label has been added.

Git tree hash: 6cba12315e3096dec6f5f273be4a51020fd0eda4

@poiana poiana merged commit ebf1ff8 into falcosecurity:master Jul 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif approved these changes

@bencer bencer Awaiting requested review from bencer

Assignees

@Issif Issif

Labels
approved area/falco-exporter-chart dco-signoff: yes kind/feature New feature or request lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jochbru @poiana @Issif