Fix redis-availability check in UI #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
dco-signoff: yes
kind/bug
|
Welcome @jegger! It looks like this is your first PR to falcosecurity/charts 🎉 |
Issif
reviewed
Jul 11, 2024
jegger
force-pushed
the
fix-redis-check-external-in-ui
branch
from
00122ca
to
0824e14
Compare
…lRedis is enabled Signed-off-by: Dominique Burnand <[email protected]>
jegger
force-pushed
the
fix-redis-check-external-in-ui
branch
from
0824e14
to
d03ac80
Compare
Issif
approved these changes
Jul 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, jegger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 86a30a86f29ff4e520fc4036e84e439f6c07a14d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind chart-release
Any specific area of the project related to this PR?
/area falco-chart
/area falcosidekick-chart
Which issue(s) this PR fixes:
It fixes the redis-availability check of the UI init-container in case external-redis is enabled. It was using the hard-coded value used when you would not use an exernal-redis.
I also upgraded the chart-version of the sidekick and flaco to get the fix also into the falco chart. It would certainly support the use I have - but I don't know if bumping two versions at once is something you do. Let me know.