Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running of k8saudit actions #725

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

cam-at-tactiq
Copy link
Contributor

What type of PR is this?

/kind bug

/kind chart-release

/area event-generator-chart

What this PR does / why we need it:

Currently users who follow the example config given here will see event-generator fail to start.

That's because the rules that match that regexp will only run when the --all flag is provided because they are marked as disabled.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is my first contribution in Falcosecurity, please let me know if there is more I can do to make this as smooth as possible for review/acceptance.

Checklist

  • Chart Version bumped
  • CHANGELOG.md updated

@poiana poiana added kind/bug Something isn't working dco-signoff: no kind/chart-release Add this label when the chart version has been bumped area/event-generator-chart labels Aug 8, 2024
@poiana poiana requested review from alacuku and bencer August 8, 2024 00:44
@poiana
Copy link
Contributor

poiana commented Aug 8, 2024

Welcome @cam-at-tactiq! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/XS label Aug 8, 2024
Signed-off-by: Cam Smith <[email protected]>
@alacuku
Copy link
Member

alacuku commented Aug 26, 2024

Hey @cam-at-tactiq, thanks for the PR. Could you please update the docs as stated here: https://github.com/falcosecurity/charts#contributing?

@cam-at-tactiq
Copy link
Contributor Author

cam-at-tactiq commented Aug 26, 2024

Hey @cam-at-tactiq, thanks for the PR. Could you please update the docs as stated here: https://github.com/falcosecurity/charts#contributing?

Hi @alacuku, what changes would you expect to see in the docs? This PR bumps the chart version and updates the changelog, but doesn't change anything user facing.

The examples given in the event-generator docs will work with this change whereas before they don't. See #723

@alacuku
Copy link
Member

alacuku commented Aug 27, 2024

It would help if you ran make docs, automatically updating the docs and fixing the broken CI.

@cam-at-tactiq
Copy link
Contributor Author

It would help if you ran make docs, automatically updating the docs and fixing the broken CI.

Done, ty

Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

LGTM label has been added.

Git tree hash: 538469df33cc3f4ab9fc32f56c153063a18bfc6f

@poiana
Copy link
Contributor

poiana commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, cam-at-tactiq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 46516b0 into falcosecurity:master Aug 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/event-generator-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants