Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of OTLP_TRACES_PROTOCOL to config.otlp.traces.protocol #742

Closed
wants to merge 3 commits into from

Conversation

carlreid
Copy link

What type of PR is this?

/kind bug
/area falcosidekick-chart

What this PR does / why we need it:

Aligns the config value config.otlp.traces.protocol with the environment variable used by Falco Sidekick.

Which issue(s) this PR fixes:

Fixes #741

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana
Copy link
Contributor

poiana commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlreid
Once this PR has been reviewed and has the lgtm label, please assign alacuku for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from bencer and Issif September 20, 2024 12:48
@poiana
Copy link
Contributor

poiana commented Sep 20, 2024

Welcome @carlreid! It looks like this is your first PR to falcosecurity/charts 🎉

@poiana poiana added the size/XS label Sep 20, 2024
@Issif
Copy link
Member

Issif commented Sep 20, 2024

Thanks for this PR, to avoid multi bumps of the version, I included your change in #740

@carlreid
Copy link
Author

Thanks for this PR, to avoid multi bumps of the version, I included your change in #740

Sure thing 👍

@alacuku
Copy link
Member

alacuku commented Sep 23, 2024

Hey @carlreid, thanks for the PR!

The issue has been already fixed: cd27c4b

@carlreid
Copy link
Author

carlreid commented Oct 5, 2024

#740 has been merged

@carlreid carlreid closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value of OTLP_TRACES_PROTOCOL is set to the endpoint
4 participants