Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falcosidekick): customConfig mount path fix for webui redis #757

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

krkjack
Copy link
Contributor

@krkjack krkjack commented Oct 9, 2024

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

redis-stack expects configuration in file /redis-stack.conf:

if [ -f /redis-stack.conf ]; then
    CONFFILE=/redis-stack.conf
fi

However currently the ConfigMap/StatefulSet templates mount the configuration over at /redis-stack.config, so it doesn't get applied despite defining customConfig in values [1] [2] [3]:

{{- if .Values.webui.redis.customConfig }}
- name: config
  mountPath: /redis-stack.config
  subPath: redis-stack.config
{{- end }}

Testing with values.yaml:

falcosidekick:
  webui:
    redis:
      customConfig: 
        - maxmemory-policy allkeys-lfu
        - maxmemory 3000mb

And running redis-cli config get maxmemory returns no configuration, whereas it should return:

1) "maxmemory"
2) "3145728000"

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

* [x]  Chart Version bumped

* [ ]  Variables are documented in the README.md

* [x]  CHANGELOG.md updated

@poiana poiana added kind/bug Something isn't working dco-signoff: no kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels Oct 9, 2024
@poiana poiana requested review from bencer and Issif October 9, 2024 07:09
@poiana poiana added the size/S label Oct 9, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@poiana poiana added the lgtm label Oct 9, 2024
@poiana
Copy link
Contributor

poiana commented Oct 9, 2024

LGTM label has been added.

Git tree hash: 0e7a30fb7a11e014706e9dcc6846de38f8f717e3

@poiana poiana added the approved label Oct 9, 2024
@Issif
Copy link
Member

Issif commented Oct 9, 2024

can you sign off your commit please?

git commit --amend
git push origin fix-redis-conf

@poiana poiana merged commit 1550223 into falcosecurity:master Oct 9, 2024
6 checks passed
@poiana
Copy link
Contributor

poiana commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, krkjack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falcosidekick-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants