fix: Use rules_files instead of deprecated rules_file in README.md config snippet #780
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using rules_file causes collision with rules_files and falco does not start ``` Tue Nov 12 14:23:17 2024: Using deprecated config key 'rules_file' (singular form). Please use new 'rules_files' config key (plural form). Error: Error reading config file (/etc/falco/falco.yaml): both 'rules_files' and 'rules_file' keys set ``` Signed-off-by: Robin Landström <[email protected]>
poiana
added
kind/documentation
|
Welcome @robinlandstrom! It looks like this is your first PR to falcosecurity/charts 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: robinlandstrom The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hey @robinlandstrom, thanks for the PR! Please review the contribution guidelines and update your PR: https://github.com/falcosecurity/charts?tab=readme-ov-file#contributing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Current snippet in chars/falco/README.md that uses
rules_filecauses collision withrules_filesand falco does not start