-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding an event on triggering rule disallowed ssh connection
#130
Conversation
) | ||
|
||
func DisallowedSSHConnection(h events.Helper) error { | ||
cmd := exec.Command("timeout", "1s", "ssh", "[email protected]", "-p", "22") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if ssh is present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @FedeDP, Let me modify it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedeDP I made changes and rule triggering successfully and throwing error too when ssh is not present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use example.com
, if there's no alternative.
@FedeDP wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FedeDP If using example.com looks good to you, then we are good to go with this PR, please take a look.
Signed-off-by: h4l0gen <[email protected]> final Signed-off-by: h4l0gen <[email protected]>
/assign @FedeDP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 0e27d3b86e3c0e1f9174f15818a7d3e486ff6e6c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, h4l0gen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
we need to detect functionality of rule
disallowed ssh connection
Which issue(s) this PR fixes:
Fixes #129
Special notes for your reviewer: